Modify the container image workflow to run mreg-cli tests #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terjekv
approved these changes
Jun 16, 2023
| - name: Load container image | ||
| run: | | ||
| docker load --input mreg.tgz | ||
| docker tag mreg ghcr.io/unioslo/mreg:latest # trick the shell script |
There was a problem hiding this comment.
I'm not sure what we're tricking here? :)
There was a problem hiding this comment.
Yeah, I could've probably worded that better.. The comment refers to run_testsuite_and_record.sh which is downloaded along with mreg-cli.
oyvindhagberg
force-pushed
the
test-with-mreg-cli
branch
from
5551f55
to
f79624c
Compare
oyvindhagberg
commented
Jun 16, 2023
Comment on lines
+73
to
+78
| - name: Load container image | ||
| run: docker load --input mreg.tgz | ||
| - name: Tag container image | ||
| # There's a docker-compose.yml file in the mreg-cli repo that wants the image from ghcr.io, | ||
| # but we want to use the newly built custom image | ||
| run: docker tag mreg ghcr.io/unioslo/mreg:latest |
There was a problem hiding this comment.
Cleaned it up a bit and wrote a better comment
There was a problem hiding this comment.
Nice, looks good! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following modifications to the "container image" workflow:
Note that Python version 3.11 is hardcoded for mreg-cli here. There's no need to run this in a matrix, because mreg-cli has been tested with multiple python versions already, before making it to the "master" branch that we download it from.