Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify container workflow to only publish on tags #531

Merged
merged 1 commit into from
May 6, 2024

Conversation

oyvindhagberg
Copy link
Contributor

This PR modifies the workflow that builds the container image so it will only be published if it is built from a tag, which will be the new way of defining a "production" version.
It also removes scheduled builds - I don't think we need them, since the image is really only used for CI and testing.
Finally, the PR updates github action versions.

Also update which action versions to use, and remove scheduled builds.
Copy link
Collaborator

@terjekv terjekv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a standard way to trigger on tags. :)

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 99.164%. remained the same
when pulling eed5c15 on update-workflows-for-trunk-based-dev
into d45d257 on master.

@oyvindhagberg oyvindhagberg merged commit eed5c15 into master May 6, 2024
44 checks passed
@oyvindhagberg oyvindhagberg deleted the update-workflows-for-trunk-based-dev branch May 6, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants