Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on patches mentioning binary file differences #25

Open
sourcefrog opened this issue Aug 7, 2024 · 0 comments · May be fixed by #26
Open

Error on patches mentioning binary file differences #25

sourcefrog opened this issue Aug 7, 2024 · 0 comments · May be fixed by #26

Comments

@sourcefrog
Copy link

From sourcefrog/cargo-mutants#391:

patch seems to return an error, or in some cases panic, on diffs that mention that a binary file changed. I guess #22 would change the panic into an error.

Some options:

  1. Just drop these messages- would work for me, but maybe other clients want to know about them?
  2. Maybe change the results to have some kind of enum indicating there was a change to a binary file? But this might be an API break to handle an edge case.
  3. Add an option to control whether to drop or error?
sourcefrog added a commit to sourcefrog/patch-rs that referenced this issue Aug 18, 2024
@sourcefrog
Handle "Binary files differ" lines
0b90edb 
Fixes uniphil#25
@sourcefrog sourcefrog linked a pull request Aug 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle "Binary files differ" lines sourcefrog/patch-rs
1 participant
@sourcefrog