Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want Unison Local UI to have a quick view for dependents of an entry #18

Open
kylegoetz opened this issue Nov 1, 2023 · 4 comments
Open

Comments

@kylegoetz
Copy link

Essentially a UI equivalent of dependents foo

@JohanWinther
Copy link
Contributor

This issue might be related: unisonweb/ui-core#26

@kylegoetz
Copy link
Author

kylegoetz commented Nov 1, 2023

Yes, it does look like it! Well spotted!

Still, I'm going to leave this issue open because that's UI Core and this is UI Local UI, and I think Local UI is not folded into the Core repo.

A cursory glance looks like the UI code for Local is here, but I guess the Core/UCM side of things is where the data for the local UI is served from, so this implementation likely requires work on both codebases.

@hojberg
Copy link
Member

hojberg commented Nov 2, 2023

This is definitely something we want. I think I've been a little worried about a good UX from Share's point of view (Share also uses ui-core) given the scope of dependents, but the UX seems simpler in Local UI.

@kylegoetz
Copy link
Author

kylegoetz commented Nov 2, 2023

I was thinking that it'd be a rolling request of dependents instead of a tree of every single one. Like for whatever element you're viewing, you fetch two levels of dependents deep. Or maybe one. And then if you drill down, same thing. So there's never a big payload.

It would be helpful for what I'm doing now: First major thing I've written, I wasn't really thinking about namespacing everything I created at first, and about halfway through I started doing it. Now I'm cleaning up, and there's a lot of one-off types that I don't remember which GetBody type it belongs to, so I'm having to trace down the dependency trees and then sort them into, say, api.Lights.GetAllResBody.ControlStatusType

Of course, more careful namespacing at the start means I never would've had this problem in the first place!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants