Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split corrected many pattern into two patterns #4846

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Split corrected many pattern into two patterns #4846

merged 2 commits into from
Mar 29, 2024

Conversation

dolio
Copy link
Contributor

@dolio dolio commented Mar 29, 2024

This rolls back the Pattern.many fix and instead adds a new builtin Pattern.many.corrected with the right behavior.

@aryairani
Copy link
Contributor

aryairani commented Mar 29, 2024 •
edited
Loading

boolean determines whether it works correctly

😅

@aryairani
Copy link
Contributor

aryairani commented Mar 29, 2024 •
edited
Loading

Not time sensitive, but I think we can use a Rename directive to affect how builtins.merge names these.

@aryairani aryairani mentioned this pull request Mar 29, 2024
Open
13 tasks
@aryairani aryairani merged commit 049b223 into trunk Mar 29, 2024
11 checks passed
@aryairani aryairani deleted the topic/many-rollback branch March 29, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryairani aryairani aryairani approved these changes

@runarorama runarorama Awaiting requested review from runarorama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dolio @aryairani