Platform & parenthesis issues #104
Conversation
Getting all new updates
Api token 79
Platform issue 88
There was a problem hiding this comment.
This addresses both issues that were opened by me today. It should address the indentation error, and it also updates all of the examples to have the proper str(), and imports. The read me was changed to reflect the changes of str() and import as well.
Just FYI, when you create a PR that refers to a specific issue that closes it, it should explicitly have in the description the following:
Closes #<NUMBER_OF_ISSUE>
This does two things. One, it's clear what issues are being referred to, and second, it automatically closes the issues in question once this PR is merged.
metriq/client.py
Outdated
| @@ -359,6 +359,13 @@ def task_get_names(self) -> List[Task]: | |||
| for r in response["data"] | |||
| ] | |||
|
|
|||
| @handler | |||
| def task_get_network(self) -> Task: | |||
There was a problem hiding this comment.
This probably should not be here, right? This is specifically related to another issue and is not correct as implemented here.
examples/task_get_network.py
Outdated
| @@ -0,0 +1,6 @@ | |||
| from metriq import MetriqClient | |||
There was a problem hiding this comment.
Similar to the other comment regarding the network task graph, this example should not be added as it will not yield the expected result and is part of your other PR.
This branch was created from my main development branch, and thus had these extra things that weren't completely worked out
I do not know if I was supposed to fix those conflicts and merge the branches, but it had a couple of errors, and I fixed them. Ie with the indentation errors, and with the read me being updated. This branch was taken off of my development branch which had all of those changes, and thus thats why we see the duplicates from the other PR |
|
Thanks, @QuantumAli ! |
This addresses both issues that were opened by me today. It should address the indentation error, and it also updates all of the examples to have the proper str(), and imports.
The read me was changed to reflect the changes of str() and import as well.