Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Default changed and changedWithHistory events override custom events #349

Closed
boynukaline opened this issue Apr 25, 2022 · 2 comments
Closed

[BUG] Default changed and changedWithHistory events override custom events #349

boynukaline opened this issue Apr 25, 2022 · 2 comments
Labels
bug Something isn't working has PR A pull request addressing this issue already exists
Milestone
v4.4.6

Comments

@boynukaline
Copy link

Describe the bug
The fix for the problem when default changed and changedWithHistory events were not created introduced the bug which overrides the current change event when a change event is added to a variable after running with empty change events.

To Reproduce
Steps to reproduce the behavior:

  1. Leave variable changed event blank and in runtime change variable value to something. Stop runtime.
  2. Add your change event to the variable, and go into runtime again and change variable value. Check variable event, it changes to default.

Environment

  • OS: [Windows 10]
  • Unity Version [2020.3.25f1]
  • Version of Unity Atoms [v4.4.4]
@boynukaline boynukaline added the bug Something isn't working label Apr 25, 2022
@soraphis
Copy link
Collaborator

#313 is the PR which introduced this bug

soraphis added a commit that referenced this issue Oct 18, 2022
@soraphis
removed ondisable method, to fix #349
cf07d55
@soraphis soraphis mentioned this issue Oct 18, 2022
Merged
@soraphis soraphis added the has PR A pull request addressing this issue already exists label Oct 18, 2022
@soraphis soraphis added this to the v4.4.6 milestone Oct 18, 2022
AdamRamberg added a commit that referenced this issue Oct 23, 2022
@soraphis @AdamRamberg
removed ondisable method, to fix #349 (#369)
b457ac3 
* removed ondisable method, to fix #349

* Remove _changed and _changedInstantiatedAtRuntime since they are not used anymore

Co-authored-by: Adam Ramberg <adam@mambojambostudios.com>
@AdamRamberg
Copy link
Collaborator

Fixed in #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working has PR A pull request addressing this issue already exists
Projects
None yet
Milestone
v4.4.6
Development

When branches are created from issues, their pull requests are automatically linked.

349-custom-events-are-overriden unity-atoms/unity-atoms
3 participants
@soraphis @AdamRamberg @boynukaline