removed ondisable method, to fix #349

[soraphis]

this addresses #349 and fixes an issue introduced with #313

when starting the runtime without changed event, it would set the "_changedInstantiatedAtRuntime" to true.

OnDisable is only called if you hit play again and are about to enter the playmode again, which then RESETS all your changes (e.g. assigning an event in edit time) to null.

the alternative would be to address this in the custom editor drawer, to set _changedInstantiatedAtRuntime to false again when _changed was set.

but I found that the OnDisable was not needed, as the values where already set back when leaving playmode and in the build (which i have not tested!! it wouldn't matter anyways since OnDisable is only called if the memory is freed altogether)

[AdamRamberg]

Looks good to me ✅ Pushed a small commit removing _changed and _changedInstantiatedAtRuntime since they are not used anymore after removing OnDisable.

[soraphis]

@AdamRamberg @soraphis
not sure anymore if this will work.

Should do a check with disables domain reload and stuff.

[AdamRamberg]

@soraphis Not sure I follow. What exactly do you think will break in this change? Do you think we should revert this before doing the next release?

[soraphis]

When i find time again, i'll need to recheck again if everything is correctly resetted.

I think if domain reload is off, neither onEnable nor onDisable are called.

So this should not break anything, but i wanna double check state is correctly cleared between playmode switches, since i'm not 100% sure what my settings in the editor where.

[AdamRamberg]

Cool! Lets wait with the release until that then

[soraphis]

ok, as far as i can tell it still works correctly even if domain+scene reload is disabled in the editor settings.
so release is good to go imho. 👍