fix #282 changed/changedwithhistory events not created when registere… #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n registered in code
miikalo
approved these changes
Nov 27, 2021
|
Hey this overrides the current change event when a change event is added to a variable. Steps to reproduce:
|
|
@boynukaline i think it would be better to create a new issue (or reopen the other issue) since this PR is already released 🙈 |
|
@soraphis Thanks, created new issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was indeed that the changed and changedWithHistory events where not created when called in code. There are 3 possible solutions I can come up with to fix this bug. One is to slightly modify the GetOrCreate() method so it can be called in the property.
Option two is to call the runtime creation code in the property itself again. This makes the GetOrCreate() method unnessesary I think?
Option 3 is to somehow add an usage for calling a variables events in code
Maybe another solution will work better than what I suggested here in this PR. Im all open for the best suggestion to tackle this problem and to update this PR.