Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value types in Sample objects should be nullable (FTV-212) #12

Closed
jcowles opened this issue May 31, 2018 · 0 comments
Closed

Value types in Sample objects should be nullable (FTV-212) #12

jcowles opened this issue May 31, 2018 · 0 comments
Labels
enhancement

Comments

@jcowles
Copy link
Contributor

jcowles commented May 31, 2018

For example, XformSample has a Matrix4x4 object, which is always written for every sample because it is not nullable.

This may make reading values trickier, so a unit test should be added to verify the round-trip API works as expected, without additional complications.
jcowles pushed a commit that referenced this issue Aug 30, 2018
Disable shading outputs to avoid writing values
c70099d 
Assigning values to these outputs will cause the connections to be ignored
which is almost always not what the user wants.

This should be addressed along with issue #12
jcowles pushed a commit that referenced this issue Jan 14, 2019
@jcowles
Disable shading outputs to avoid writing values
10297ac 
Assigning values to these outputs will cause the connections to be ignored
which is almost always not what the user wants.

This should be addressed along with issue #12
@mfe mfe changed the title Value types in Sample objects should be nullable Value types in Sample objects should be nullable (FTV-212) Jun 12, 2019
jcowles added a commit that referenced this issue Jul 17, 2019
@jcowles
PreviewSurface: Make outputs explicit
bbf07ae 
Now that Nullable<T> is handled correctly and null values still trigger the attribute to be defined in USD, now shader outputs can be made explicit and adhere to the USD spec.

Fixes #12
jcowles added a commit that referenced this issue Jul 18, 2019
@jcowles
PreviewSurface: Make outputs explicit
7a77750 
Now that Nullable<T> is handled correctly and null values still trigger the attribute to be defined in USD, now shader outputs can be made explicit and adhere to the USD spec.

Fixes #12
@jcowles jcowles mentioned this issue Jul 18, 2019
Merged
jcowles added a commit that referenced this issue Jul 19, 2019
@jcowles
PreviewSurface: Make outputs explicit
d432724 
Now that Nullable<T> is handled correctly and null values still trigger the attribute to be defined in USD, now shader outputs can be made explicit and adhere to the USD spec.

Fixes #12
jcowles added a commit that referenced this issue Jul 19, 2019
@jcowles
PreviewSurface: Make outputs explicit
5eba0bd 
Now that Nullable<T> is handled correctly and null values still trigger the attribute to be defined in USD, now shader outputs can be made explicit and adhere to the USD spec.

Fixes #12
@mfe mfe closed this as completed in 4ba998d Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mfe @jcowles