Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to github actions #167

Merged
merged 6 commits into from
Oct 31, 2021
Merged

Migrate to github actions #167

merged 6 commits into from
Oct 31, 2021

Conversation

perrin4869
Copy link
Collaborator

Change of pace PR
We need to add NPM_TOKEN as an organization secret to publish package, but this should be good otherwise

@coveralls
Copy link

coveralls commented Oct 26, 2021 •
edited
Loading

Coverage Status

Coverage increased (+97.3%) to 97.285% when pulling b95f4a7 on chore/perrin4869/github-actions into 1e07717 on master.

@perrin4869
Copy link
Collaborator Author

perrin4869 commented Oct 26, 2021 •
edited
Loading

Coverage is fixed!

Edit: Fixes #167

@perrin4869 perrin4869 mentioned this pull request Oct 28, 2021
Closed
@phieronymus
Copy link
Collaborator

@perrin4869 Very nice! Thanks 🙂 Should we remove cicrcle ci from the equation as well?

@perrin4869
Copy link
Collaborator Author

Yeah no more need for circle ci!
After we merge I can quickly put together a similar one for the private repo

@phieronymus
Copy link
Collaborator

Merging this PR. Thanks a lot for the update 🙂

@phieronymus phieronymus merged commit 29f3e6c into master Oct 31, 2021
@phieronymus phieronymus deleted the chore/perrin4869/github-actions branch October 31, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdebono jdebono jdebono approved these changes

@laxa88 laxa88 laxa88 approved these changes

@5ym 5ym Awaiting requested review from 5ym

@yukimogu yukimogu Awaiting requested review from yukimogu

@YusukeFukushima YusukeFukushima Awaiting requested review from YusukeFukushima

@phieronymus phieronymus Awaiting requested review from phieronymus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@perrin4869 @coveralls @phieronymus @laxa88 @jdebono