Support event emitters from PaymentsSDK and Resource #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
This works by using the
newListener
andremoveListener
events - whenever theResource
orPaymentsSDK
gets an event handler, it is relayed to the underlyingapi
object.However,
eventemitter3
doesn't support these built-in events, so it had to be replaced with a more straightforwardnode
polyfill. The good thing here is that in node environments, we'll just keep using the regular node module. The bad news is that standard node typings are not as strict as theeventemitter3
typings - these do not support generics, so the events are not type safe anymore.