Be smarter about adding new Marathon tasks to Consul #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Preparing for updating task registration
* Don't sync the whole app, just the task and the app labels.
|
Ready for review. Read commit-by-commit. The first commit is the hardest to read but it's just a refactoring. |
|
👍 but we should do something about that |
JayH5
added a commit
that referenced
this pull request
Oct 27, 2015
…ent-smarter Be smarter about adding new Marathon tasks to Consul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive an event from Marathon that a new task has come online, we sync the whole app associated with the task.
The event gives us all the information about the task necessary to register a service in Consul. We just need to fetch the app definition from Marathon to get the labels.