Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST for camera entities #109

Closed
pergolafabio opened this issue Aug 2, 2023 · 5 comments · Fixed by #264
Closed

REQUEST for camera entities #109

pergolafabio opened this issue Aug 2, 2023 · 5 comments · Fixed by #264

Comments

@pergolafabio
Copy link

Is your feature request related to a problem? Please describe.
Hi , it it possible to create also support for camera entities, to upload maybe jpg pictures files?

thnx in advance

@pergolafabio
Copy link
Author

And maybe also for the Mqtt image platform?

https://www.home-assistant.io/integrations/image.mqtt/

@Gifford47
Copy link
Contributor

That would be awesome! @unixorn can you give me a hint how to start implementing?

@unixorn
Copy link
Owner

unixorn commented Oct 16, 2024

Sorry it's taken so long to respond, I've had a hectic few weeks.

I don't currently have any cameras connected to my HA to do any testing.

After looking at the image.mqtt link upthread, I think adding payload_available, payload_not_available and url_topic topics to an object would do it, but I can't test.

RN I can't really do much in the way of implementing features I'm not using because my life's a bit hectic lately. I am happy to merge in new code - I make a point to check at least every weekend for PRs.

@Gifford47
Copy link
Contributor

Thanks for this awesome lib! I've added camera, image and selection discovery in #264. I've tested it manually on my host machine, so I've not added any tests to this repo yet. Do you merge it also without the tests?

@unixorn
Copy link
Owner

unixorn commented Oct 19, 2024

I'd prefer tests but you can add them in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants