Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting giget clone options #112

Merged
merged 6 commits into from
Oct 19, 2023
Merged

feat: allow setting giget clone options #112

merged 6 commits into from
Oct 19, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 19, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR allows setting giget cloning options both with top level loadConfig and also in each extends layer using layer meta:

export default defineConfig({
  theme: "./theme",
  extends: [
    ["gh:user/repo", { giget: { auth: process.env.GITHUB_AUTH } }],
  ]
})

Also unblocks #51 since once we support this feature in giget, (unjs/giget#6), giget: { installDependencies: true } would allow installing layer dependencies!

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #112 (038f98b) into main (a8b73c2) will increase coverage by 0.24%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 038f98b differs from pull request most recent head af13d45. Consider uploading reports for the commit af13d45 to get more accurate results

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   77.93%   78.17%   +0.24%     
==========================================
  Files           5        5              
  Lines         716      724       +8     
  Branches       65       65              
==========================================
+ Hits          558      566       +8     
  Misses        158      158              
Files Coverage Ξ”
src/loader.ts 90.31% <100.00%> (+0.12%) ⬆️
src/types.ts 95.53% <100.00%> (+0.16%) ⬆️

@pi0 pi0 merged commit c28b776 into main Oct 19, 2023
1 check passed
@pi0 pi0 mentioned this pull request Oct 19, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant