Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only access latest tag accessible from current branch #69

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Mar 2, 2023

On Nuxt framework repo, for example, we have multiple branches. 2.x branch continues having new tags, but these are irrelevant for main branch. This updates git command to use only the latest accessible tag.

@danielroe danielroe added the bug Something isn't working label Mar 2, 2023
@danielroe danielroe requested a review from pi0 March 2, 2023 16:23
@danielroe danielroe self-assigned this Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #69 (950a692) into main (a5ab510) will increase coverage by 0.45%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   84.07%   84.53%   +0.45%     
==========================================
  Files           6        6              
  Lines         559      556       -3     
  Branches       80       80              
==========================================
  Hits          470      470              
+ Misses         89       86       -3     
Impacted Files Coverage Δ
src/git.ts 88.66% <0.00%> (+1.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@pi0 pi0 merged commit b2e8ae9 into main Mar 3, 2023
@pi0 pi0 deleted the fix/git-tag branch March 3, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants