Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support number arg type #73

Merged
merged 12 commits into from
Mar 18, 2024
Merged

feat: support number arg type #73

merged 12 commits into from
Mar 18, 2024

Conversation

Barbapapazes
Copy link
Member

πŸ”— Linked issue

fix #23
fix #71

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR allow user to define args as number. Implementation is similar to string or boolean args.

#72 must be updated to reflect this change if this PR is merged before

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes Barbapapazes added the enhancement New feature or request label Sep 13, 2023
@Barbapapazes Barbapapazes self-assigned this Sep 13, 2023
@Barbapapazes Barbapapazes mentioned this pull request Sep 13, 2023
8 tasks
@pi0 pi0 changed the title feat: support number as args feat: support number arg type Mar 18, 2024
@pi0 pi0 merged commit 7ee947b into main Mar 18, 2024
2 checks passed
@pi0 pi0 deleted the feat/support-arg-number branch March 18, 2024 14:42
@Barbapapazes Barbapapazes mentioned this pull request Jul 5, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support number for type args number type
2 participants