Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global publish method #35

Closed
wants to merge 4 commits into from
Closed

Conversation

CS-Birb
Copy link

@CS-Birb CS-Birb commented Apr 17, 2024

πŸ”— Linked issue

resolves #29

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Provides means for the crossws adapters that support pub/sub (bun, node and uws) to publish to a topic without holding onto a Peer. This will help support messages being initiated from other server contexts - rather than just in response to a Peer.

Open to input on alternative approaches - I expect this might not be quite at the desired quality just yet.

Not clear how this proposed feature would best integrate into downstream packages like h3 or Nitro. Open to any discussion!

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 self-assigned this Aug 2, 2024
@pi0 pi0 changed the title feat: publish without peer feat: global publish method Aug 2, 2024
@pi0
Copy link
Member

pi0 commented Aug 6, 2024

Hi. thanks for PR. Please see #61 for alternative approach. (we can implicitly access server instance from one of the peers considering publish only makes sense with at least one client)

@pi0 pi0 closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish without peer
2 participants