Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusting regex to allow / in git refs #102

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

nick-genesis
Copy link
Contributor

@nick-genesis nick-genesis commented Aug 15, 2023

πŸ”— Linked issue

#101

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Allow parseGitURI to correctly parse git refs that include slashes.

This is a pretty common pattern org/repo#username/ABC-123 which does not currently get parsed correctly as the ref capturing group in the regex is too strict.

Resolves #101

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly. (N/A)

@nick-genesis
Copy link
Contributor Author

@pi0 have you had a chance to look at this by any chance?
Would be great if we could get it merged soon, thanks!

@pi0 pi0 changed the title fix: adjusting regex to allow / in git refs #101 fix: adjusting regex to allow / in git refs Sep 7, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nick-genesis
Copy link
Contributor Author

@pi0 thanks for approving, will you be merging this soon?
Let me know if you need anything else from my side.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #102 (e4a9316) into main (5ea5d96) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   71.49%   71.49%           
=======================================
  Files           6        6           
  Lines         442      442           
  Branches       43       43           
=======================================
  Hits          316      316           
  Misses        126      126           
Files Coverage Ξ”
src/_utils.ts 75.36% <100.00%> (ΓΈ)

@pi0 pi0 merged commit 8eb4b26 into unjs:main Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git refs that include slashes do not get parsed correctly
3 participants