Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to sharp 0.33 with installation enahancenments #190

Closed
wants to merge 4 commits into from

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 10, 2023

πŸ”— Linked issue

lovell/sharp#3750

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR is a preview for sharp@0.33 alpha releases with the removal of the install script and dedicated per-arch packages + experimental WASM package πŸ₯³ (note: It is still Node.js only. Workers without thread support do not work!)

See lovell/sharp#3750 for more details.

πŸ§ͺ Try via nightly channel

Preview is published under ipx-nightly release channel.

Method 1: If you are directly using ipx as a dependency, change package.json dependency to use npm:ipx-nightly@latest as version.

{
  "dependencies": {
--    "ipx": "latest",
++    "ipx": "npm:ipx-nightly@latest",
  }
}

Method 2: If you are indirectly using ipx You can add resolutions field in package.json to override the package:

{
  "resolutions": {
    "ipx": "npm:ipx-nightly@latest"
  }
}

Important: See nuxt/image#1102 for Nuxt image instructions

πŸ› Issues

CI seems to be passing well. I have discovered some issues with nuxt/image#1102 which are unrelated.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #190 (9dcb0be) into main (675ab59) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   54.10%   54.10%           
=======================================
  Files          11       11           
  Lines        1083     1083           
  Branches       45       45           
=======================================
  Hits          586      586           
  Misses        497      497           

@pi0 pi0 changed the title feat: upgrade to sharp 0.33 with overhaul of installation enahancenments feat: upgrade to sharp 0.33 with installation enahancenments Nov 10, 2023
@DavidDeSloovere
Copy link

Just wanted to let you know that sharp 0.33.0 has been released (there already a 0.33.1). Was looking at this hoping CF Workers/Pages would work, but I now know that the lack of thread support is blocking.

@pi0
Copy link
Member Author

pi0 commented Jan 12, 2024

Merged in main for ipx v3

@pi0 pi0 closed this Jan 12, 2024
@pi0 pi0 deleted the feat/sharp-33 branch January 12, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants