Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support URL input for link renderer #12

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

mahdikhashan
Copy link
Contributor

πŸ”— Linked issue

#9

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

is resolves #9

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

❗ No coverage uploaded for pull request base (main@f3c42b7). Click here to learn what that means.

❗ Current head 37af357 differs from pull request most recent head 7e48540. Consider uploading reports for the commit 7e48540 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #12   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         2           
  Lines           ?       293           
  Branches        ?        25           
========================================
  Hits            ?       293           
  Misses          ?         0           
  Partials        ?         0           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@mahdikhashan mahdikhashan marked this pull request as ready for review February 6, 2024 23:19
src/render.ts Show resolved Hide resolved
@pi0 pi0 changed the title type: link url type feat: support URL input for link Feb 7, 2024
@pi0 pi0 changed the title feat: support URL input for link feat: support URL input for link renderer Feb 7, 2024
@pi0 pi0 merged commit 9a3d151 into unjs:main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type: there could be a type for URL in link util function to prevent raw string to be passed as a valid url
2 participants