Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace fast-glob with tinyglobby #237

Merged
merged 5 commits into from
Oct 5, 2024

Conversation

SuperchupuDev
Copy link
Contributor

@SuperchupuDev SuperchupuDev commented Aug 15, 2024

fast-glob - 17 subdependencies
tinyglobby - 2 subdependencies

Like #230, but it switches to an even smaller library

Ref: https://github.com/es-tooling/module-replacements/blob/main/docs/modules/glob.md#tinyglobby

Package size report
===================

Package info for "mkdist@1.5.4": 35 MB
  Released: 2024-07-16 18:18:05.689 +0000 UTC (4w1d ago)
  Downloads last week: 33,732 (42.59%)
  Estimated traffic last week: 1.2 TB
  Subdependencies: 126

Removed dependencies:
  - fast-glob@3.3.2: 512 kB (1.45%)
    Downloads last week: 26,156,119 (N/A% from 3.3.2)
    Downloads last week from "mkdist@1.5.4": 33,732 (N/A%)
    Traffic last week: N/A
    Traffic from "mkdist@1.5.4": 1.2 TB (N/A%)
    Subdependencies: 17 (13.49%)

Added dependencies:
  + tinyglobby@0.2.2: 171 kB (0.48%)
    Downloads last week: 64,157 (N/A% from 0.2.2)
    Estimated traffic last week: N/A
    Subdependencies: 2 (1.58%)

Estimated new statistics:
  Package size: 35 MB → 35 MB (98.87%)
  Subdependencies: 126 → 111 (-15)
  Traffic with last week's downloads:
    For current version: 1.2 TB → 1.2 TB (13 GB saved)
    For all versions: 2.8 TB → 2.8 TB (31 GB saved)

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (9000888) to head (2a10239).
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   82.86%   81.04%   -1.82%     
==========================================
  Files          12       12              
  Lines         852      823      -29     
  Branches      133      172      +39     
==========================================
- Hits          706      667      -39     
- Misses        144      154      +10     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Considering the API is now closer and tinyglobby is best available alternative today.

@pi0 pi0 merged commit 82b7c9a into unjs:main Oct 5, 2024
3 of 4 checks passed
@SuperchupuDev SuperchupuDev deleted the refactor/tinyglobby branch October 5, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants