Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce usage of event.node.req #1511

Merged
merged 5 commits into from
Jul 31, 2023
Merged

refactor: reduce usage of event.node.req #1511

merged 5 commits into from
Jul 31, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 31, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR migrates most of internals to prefer top level or h3 utils instead of depending to event.node.req. (unjs/h3#73)

One major remaining part, is cachedEventHandler which currently uses a mock req, res. unjs/h3#472 might cover this!

Note: Deno is broken since installs h3 latest instead of rc (current dep)! Enabling tests after fixing it.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Jul 31, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 41900a9

@pi0 pi0 changed the title refactor: avoid usage ofevent.node.req refactor: reduce usage of event.node.req Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1511 (535fe92) into main (f71cdeb) will decrease coverage by 0.06%.
The diff coverage is 25.00%.

❗ Current head 535fe92 differs from pull request most recent head 41900a9. Consider uploading reports for the commit 41900a9 to get more accurate results

@@            Coverage Diff             @@
##             main    #1511      +/-   ##
==========================================
- Coverage   76.22%   76.16%   -0.06%     
==========================================
  Files          73       73              
  Lines        7456     7456              
  Branches      732      731       -1     
==========================================
- Hits         5683     5679       -4     
- Misses       1772     1775       +3     
- Partials        1        2       +1     
Files Changed Coverage Ξ”
src/dev/vfs.ts 9.44% <25.00%> (ΓΈ)

... and 1 file with indirect coverage changes

@pi0 pi0 merged commit 2ecd9fa into main Jul 31, 2023
4 of 5 checks passed
@pi0 pi0 deleted the refactor/h3-event branch July 31, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant