Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): support for /_vfs.json #809

Merged
merged 3 commits into from
Jan 9, 2023
Merged

feat(dev): support for /_vfs.json #809

merged 3 commits into from
Jan 9, 2023

Conversation

antfu
Copy link
Collaborator

@antfu antfu commented Jan 6, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This could be useful for other integrations to get the data and render it in their own style.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition πŸ‘πŸΌ

@pi0
Copy link
Member

pi0 commented Jan 6, 2023

Can you please check prettier formating issue?

@vercel
Copy link

vercel bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
unjs-nitro πŸ”„ Building (Inspect) Jan 6, 2023 at 2:08PM (UTC)

@antfu
Copy link
Collaborator Author

antfu commented Jan 6, 2023

ESLint seems to have conflicts with Prettier in this case. What's your preference to fix it?

@antfu antfu mentioned this pull request Jan 6, 2023
11 tasks
@pi0
Copy link
Member

pi0 commented Jan 6, 2023

. What's your preference to fix it?

We should disable formatting rules from eslint config (some are still on) fixing on branch

@pi0 pi0 merged commit 3f8ca7a into main Jan 9, 2023
@pi0 pi0 deleted the feat/vfs_json branch January 9, 2023 15:32
pi0 pushed a commit that referenced this pull request Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants