Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg): add export conditions for runtime keys #246

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 6, 2023

Resolves #238

Following runtime-keys proposal.

Support export conditions for browser, bun, deno, edge-light, edge-routine, lagon, netlify, react-native, wintercg, worker, workerd with global fetch availability

Related topics: wintercg/runtime-keys#5 and nitrojs/nitro#1123)

@pi0 pi0 changed the title fix(pkg): add worker and workerd export conditions fix(pkg): add export conditions for worker runtimes Jun 6, 2023
@pi0 pi0 changed the title fix(pkg): add export conditions for worker runtimes feat(pkg): add export conditions for worker runtimes Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #246 (49f3311) into main (9f570b7) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 49f3311 differs from pull request most recent head 724f743. Consider uploading reports for the commit 724f743 to get more accurate results

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   86.63%   86.76%   +0.12%     
==========================================
  Files           5        5              
  Lines         419      423       +4     
  Branches       66       68       +2     
==========================================
+ Hits          363      367       +4     
  Misses         56       56              

see 1 file with indirect coverage changes

@pi0 pi0 changed the title feat(pkg): add export conditions for worker runtimes feat(pkg): add export conditions for runtime keys Jun 6, 2023
@pi0 pi0 merged commit 4d5f928 into main Jun 6, 2023
@pi0 pi0 deleted the fix/worker-conditions branch June 6, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with Next.js Edge API runtime using edge-light condition
1 participant