fix: pass missing esbuild jsx factory options #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unbuild/src/builder/plugins/esbuild.ts
Lines 14 to 21 in a7b73c3
The type definition is here, but not passing to esbuild transform. And there is another JSX related PR #198.
By the way, I think it is necessary to pass the full esbuild transform options like vite?
https://github.com/vitejs/vite/blob/a1019f80a5d5b6242d8fb0975994ce1ae6e78e94/packages/vite/src/node/plugins/esbuild.ts#L35-L43
There is some related esbuild options PR #190 #192