Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't clean root directory if set as outDir #343

Merged
merged 3 commits into from
Dec 18, 2023
Merged

fix: don't clean root directory if set as outDir #343

merged 3 commits into from
Dec 18, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Let us draw a curtain of charity over how I discovered this issue.

I also considered warning + continue in this case but thought there would be valid use cases, such as wanting ./src/my-file.ts to output to ./some-file.js. However, if this is too edge-casey, I think we could add a warning as well.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Dec 6, 2023
@danielroe danielroe requested a review from pi0 December 6, 2023 07:31
@danielroe danielroe self-assigned this Dec 6, 2023
src/build.ts Show resolved Hide resolved
@pi0 pi0 merged commit 5bcd226 into main Dec 18, 2023
2 checks passed
@pi0 pi0 deleted the fix/root-clean branch December 18, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants