Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: same text and url #68

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: same text and url #68

wants to merge 5 commits into from

Conversation

Barbapapazes
Copy link
Member

@Barbapapazes Barbapapazes commented Nov 2, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If a link looks like this [./example](./example), current implementation will return [https://raw.githubusercontent.com/example](./example), which is not the expected behavior.

This PR fixes this issue by checking replacing the link but not the text.

we could start adding some using testing to validate utils functions and edge cases

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Barbapapazes Barbapapazes self-assigned this Nov 2, 2023
@Barbapapazes Barbapapazes requested a review from pi0 November 2, 2023 15:36
if (url) {
return match.replace(
`(${path})`,
`(${cdnBaseURL}/${path.replace(/^\.\//, "")})`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please double-check if we could fix/improve the regex above? generating new (${path}) seems hacky to replace while haven't tried it locally... Also what is a sample README URL we can test against?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here some readme where there is the issue: #68 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the regexp to simplify code and avoid too many if.

@Barbapapazes Barbapapazes requested a review from pi0 January 10, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants