Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redis): fix clear method #163

Merged
merged 3 commits into from
Feb 27, 2023
Merged

fix(redis): fix clear method #163

merged 3 commits into from
Feb 27, 2023

Conversation

jamwong-ecosa
Copy link
Contributor

fix #162

@danielroe danielroe mentioned this pull request Feb 23, 2023
Merged
danielroe
danielroe approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Enabled unit test on redis as well: #164. Once that's enabled the test I've added here should prevent regression on this bug.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #163 (5d87db9) into main (1a9c013) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #163   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files          15       15           
  Lines        1344     1344           
  Branches      303      303           
=======================================
  Hits         1201     1201           
  Misses        143      143

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@itpropro
Copy link
Member

Should also be fixed in #160 @danielroe 😃

@pi0 pi0 changed the title bug fix on redis clear method fix(redis): fix clear method Feb 27, 2023
pi0
pi0 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 90980e0 into unjs:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot clear the cache with redis driver
4 participants
@jamwong-ecosa @itpropro @pi0 @danielroe