Added validation for Google Analytics Campaign Tagging required fields (Issue29)

[petervnguyen99]

Pull Request For Issue #29
Added validation for Google Analytics Campaign Tagging required fields

Also simplified the display of the Go URL page by removing the shorten and show more buttons and displaying the Custom Alias and Google Analytics Campaign Tagging forms. With the Google Analytics Campaign Tagging form we added a checkbox which shows the form if checked and will reset the form if unchecked.

[jsturek]

• config.sample.php should not be deleted or edited (unless for new config ALL users of the repo will need). You are supposed to copy the file to config.inc.php and edit that file for your server's config. Please add the file back with no changes.

[jsturek]

If you want to make the google stuff available if javascript is disabled and work as desired when it is you can do the following:

• Remove style from ga-tagging div so it displays by default
• Hide by default all items we don't want to display when javascript is off by adding a class to identify these items, say ga-js-item and add style of display: none to hide.
  ** Hide google checkbox since not needed without javascript
  ** Hide the required google form items required spans since conditionally required
• Add the following javascript to the google processing javascript:

// set up default display since javascript is available
    // show javascript dependent items
    var gaJSItems = document.getElementsByClassName('ga-js-item');
    for (var j=0; j<gaJSItems.length; j++) {
      gaJSItems[j].style.display = 'block';
    }
    // Hide google section by default
    gaSection.style.display = 'none';

[jsturek]

See requested changes and suggestions

[jsturek]

Changes look good. Thanks.

You should probably update the name/title of the PR to something descriptive and add a link to the issue in the description stating that the update addresses the issue. We don't have a formal convention for PRs for issues yet but it will be something like this.

[jsturek]

Barring further changes I approve this PR.

[jsturek]

Looks good.