Skip to content
This repository has been archived by the owner on Aug 20, 2019. It is now read-only.

Change title to reflect what page the user is on. #235

Merged
merged 3 commits into from
Apr 5, 2017
Merged

Change title to reflect what page the user is on. #235

merged 3 commits into from
Apr 5, 2017

Conversation

a-weiss-programmer
Copy link
Contributor

Addresses #11

@djw8605
Copy link
Collaborator

djw8605 commented Mar 27, 2017 via email

@djw8605
Copy link
Collaborator

djw8605 commented Mar 28, 2017

You can't use angular.element to select the title. Really, you should be using {{ title }} and then bind the title from the controller to the service.

Copy link
Collaborator

@djw8605 djw8605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this is the wrong way to do this. There are a lot of ways to change pages, without going through navservice, for example, going from the job submission page back to the Home.

I would recommend looking at this page:
http://stackoverflow.com/a/13407227/3357060

And using a binding, rather than setting angular.element

@djw8605
Copy link
Collaborator

djw8605 commented Apr 5, 2017

Awesome! does this all work?

@a-weiss-programmer
Copy link
Contributor Author

Yep! I will accept any and all git blame :)

@djw8605
Copy link
Collaborator

djw8605 commented Apr 5, 2017

I think this will lead to the side panel being much more useful!

Copy link
Collaborator

@djw8605 djw8605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@djw8605 djw8605 merged commit 4fd2051 into unlhcc:master Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants