fix(unlock-app): Checkout refactor #13814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien51
reviewed
May 9, 2024
| @@ -25,14 +25,14 @@ export function Connected({ service, children }: ConnectedCheckoutProps) { | |||
| // Skip Connect if already signed in | |||
| const autoSignIn = async () => { | |||
There was a problem hiding this comment.
Can you please check that this does not break flows where the paywall is used as an "embed" and the provider is passed by the calling application? That's what dirt.fyi or bestdishever are using.
Check this https://github.com/unlock-protocol/unlock/tree/master/packages/paywall#passing-a-provider
julien51
approved these changes
May 13, 2024
SVell
added a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored checkout and unlock account sign in
Checklist: