Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update to net8.0 to fix canary #1111

Merged
merged 9 commits into from
Jun 5, 2024

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Project automation
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 force-pushed the dev/youssef/fix-canary branch 3 times, most recently from d9f8b92 to e427bb0 Compare May 21, 2024 09:04
@jeromelaban
Copy link
Member

@Youssef1313 the migration is already done in the single project branch

@Youssef1313
Copy link
Member Author

@jeromelaban The other PR isn't yet complete, doesn't adjust the CI for example. This was meant to be a quicker change to get canary working again soon, and possibly will make the single project migrarion easier as the CI will be set up right with .NET 8

@agneszitte
Copy link
Contributor

agneszitte commented May 23, 2024

@Youssef1313 I think the goal would be to do this work on the #1104 related changes. As the goal would be to migrate Gallery to single project as well. (Related discussion).

@Youssef1313
Copy link
Member Author

@Youssef1313 I think the goal would be to do this work on the #1104 related changes. As the goal would be to migrate Gallery to single project as well. (Related discussion).

I guess we can make it in two steps, first updating to net8.0, which is more important for now, then continue the single project migration (which will mostly build on top of the net8.0 update).

@Youssef1313 Youssef1313 marked this pull request as draft June 4, 2024 20:15
@Youssef1313
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jeromelaban jeromelaban marked this pull request as ready for review June 5, 2024 20:29
@jeromelaban jeromelaban merged commit c3ebda2 into unoplatform:master Jun 5, 2024
14 checks passed
@Youssef1313 Youssef1313 deleted the dev/youssef/fix-canary branch June 5, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants