Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ItemsControl for ItemsRepeater #962

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

rafael-rosa-knowcode
Copy link
Contributor

GitHub Issue (If applicable): #

Issue: unoplatform/uno.toolkit.ui#798
PR: unoplatform/uno.toolkit.ui#807

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Now when the Calculator remove the item, the size is not been resized.

What is the new behavior?

When we remove items, the size is been updated.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-962.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-962.eastus2.3.azurestaticapps.net

@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/4x

@mergify
Copy link

mergify bot commented Sep 5, 2023

backport legacy/4x

✅ Backports have been created

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-962.eastus2.3.azurestaticapps.net

@agneszitte agneszitte force-pushed the dev/ramr/ItemsRepeaterCalculator branch from 80c5ef2 to 2dd5fce Compare September 6, 2023 06:15
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-962.eastus2.3.azurestaticapps.net

@agneszitte agneszitte marked this pull request as ready for review September 6, 2023 06:32
@agneszitte agneszitte self-assigned this Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-962.eastus2.3.azurestaticapps.net

@jeromelaban jeromelaban merged commit 3aaac00 into master Sep 6, 2023
13 of 15 checks passed
@jeromelaban jeromelaban deleted the dev/ramr/ItemsRepeaterCalculator branch September 6, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ShadowContainer][All Platforms] ShadowContainer not resizing properly
5 participants