Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: lightweight styling #1118

Merged
merged 1 commit into from
Aug 17, 2023
Merged

docs: lightweight styling #1118

merged 1 commit into from
Aug 17, 2023

Conversation

rajamatt
Copy link
Contributor

GitHub Issue: #1063

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

Description

  • Adds general documentation for lightweight styling.
  • Adds two image assets.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

@rajamatt rajamatt self-assigned this Jul 31, 2023
Xiaoy312
Xiaoy312 reviewed Jul 31, 2023
View reviewed changes
doc/lightweight-styling.md Outdated Show resolved Hide resolved
doc/lightweight-styling.md Outdated Show resolved Hide resolved
doc/lightweight-styling.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from 2caf0a2 to 1ee5c61 Compare August 1, 2023 15:06
@github-actions
Copy link

github-actions bot commented Aug 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@rajamatt rajamatt marked this pull request as ready for review August 1, 2023 15:07
@github-actions
Copy link

github-actions bot commented Aug 1, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

kazo0
kazo0 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@kazo0 kazo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing I would add is a link to https://learn.microsoft.com/en-us/windows/apps/design/style/xaml-styles#lightweight-styling as a further reading

@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from b633ba4 to beebcd7 Compare August 8, 2023 14:02
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

kazo0
kazo0 reviewed Aug 8, 2023
View reviewed changes
doc/lightweight-styling.md Outdated Show resolved Hide resolved
doc/lightweight-styling.md Outdated Show resolved Hide resolved
@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from cb21177 to c49ef55 Compare August 8, 2023 15:41
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@rajamatt rajamatt marked this pull request as draft August 8, 2023 16:39
@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from 1f968d5 to 1992dfd Compare August 8, 2023 16:41
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

3 similar comments
@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@kazo0 kazo0 changed the title docs: added general lightweight styling docs: lightweight styling Aug 8, 2023
@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from 4860d91 to 0818470 Compare August 14, 2023 14:44
@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

mrlacey
mrlacey reviewed Aug 14, 2023
View reviewed changes
doc/lightweight-styling.md Outdated Show resolved Hide resolved
mrlacey
mrlacey reviewed Aug 14, 2023
View reviewed changes
doc/lightweight-styling.md Outdated Show resolved Hide resolved
@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from d215379 to 0c58b21 Compare August 15, 2023 15:51
@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from 2ed69e0 to b5cd3a3 Compare August 15, 2023 16:26
@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@rajamatt
docs: added general lightweight styling
12ee262 
fix: links

docs: lightweight styling

docs: added xref

docs: lightweight styling
@rajamatt rajamatt force-pushed the dev/mara/docs-lightweight-styling branch from 33c31fc to 12ee262 Compare August 16, 2023 20:44
@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1118.eastus2.azurestaticapps.net

@agneszitte
Copy link
Contributor

Last sanity check @jeromelaban, @Xiaoy312, @pictos please

@agneszitte agneszitte merged commit ad6aee4 into master Aug 17, 2023
5 checks passed
@agneszitte agneszitte deleted the dev/mara/docs-lightweight-styling branch August 17, 2023 17:38
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 17, 2023 •
edited
Loading

backport legacy/2x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@agneszitte agneszitte agneszitte left review comments

@jeromelaban jeromelaban jeromelaban left review comments

@kazo0 kazo0 kazo0 approved these changes

@weitzhandler weitzhandler weitzhandler left review comments

@mrlacey mrlacey mrlacey left review comments

@pictos pictos pictos approved these changes

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

Assignees

@rajamatt rajamatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Material] Lightweight Styling - Documentation
9 participants
@rajamatt @agneszitte @mrlacey @Xiaoy312 @weitzhandler @kazo0 @jeromelaban @pictos @Youssef1313