Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alternateContent): fix toggleButton alternate content visual states #1290

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

Arieldelossantos
Copy link
Contributor

GitHub Issue:

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

Before After
togglebutton-broken togglebutton-fixed

PR Checklist

Please check if your PR fulfills the following requirements:

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1290.eastus2.azurestaticapps.net

@Xiaoy312
Copy link
Contributor

another potential candidates for: #1286
attached properties in library code:

Target Source Value
AlternateContentPresenter.Opacity CommonStates\Checked {Binding Path=(um:ControlExtensions.AlternateContent), RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource MaterialNullToTransparent}, FallbackValue=1, TargetNullValue=1}
AlternateContentPresenter.Opacity CommonStates\CheckedDisabled {Binding Path=(um:ControlExtensions.AlternateContent), RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource MaterialNullToTransparent}, FallbackValue=1, TargetNullValue=1}
AlternateContentPresenter.Opacity CommonStates\CheckedPointerOver {Binding Path=(um:ControlExtensions.AlternateContent), RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource MaterialNullToTransparent}, FallbackValue=1, TargetNullValue=1}
AlternateContentPresenter.Opacity CommonStates\CheckedPressed {Binding Path=(um:ControlExtensions.AlternateContent), RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource MaterialNullToTransparent}, FallbackValue=1, TargetNullValue=1}

@Arieldelossantos you can ignore this message, this is just for documenting

@Arieldelossantos Arieldelossantos changed the title fix(alternateContent): fix toggleButton alternate control visual states fix(alternateContent): fix toggleButton alternate content visual states Nov 28, 2023
@kazo0 kazo0 merged commit ef221bd into master Nov 29, 2023
11 checks passed
@kazo0 kazo0 deleted the dev/arde/fix-toggle-button-alternate-content branch November 29, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants