Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix top navigation view foreground #1359

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Feb 18, 2024

GitHub Issue: closes #1317

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@kazo0
Copy link
Collaborator

kazo0 commented Feb 19, 2024

might conflict/be addressed by #1353

@Youssef1313
Copy link
Member Author

@kazo0 Do we expect #1353 to get merged soon?

@Youssef1313
Copy link
Member Author

Actually, most lines modified here are not modified in #1353

@Youssef1313
Copy link
Member Author

@kazo0 Is this ready to merge?

@kazo0 kazo0 merged commit b26fd5c into unoplatform:master Feb 25, 2024
19 checks passed
@Youssef1313 Youssef1313 deleted the issues/1317 branch February 25, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavigationView's selected option disappears when PaneDisplayMode is setted as Top
2 participants