chore: Refactor package packing #26
Conversation
Youssef1313
force-pushed
the
refactor-packaging
branch
from
316ad68
to
d38acd9
Compare
| <Target Name="_UnoAddPriMarker" AfterTargets="ResolvePackageAssets"> | ||
| <_UnoPriFiles Include="$(MSBuildThisFileDirectory)uno.fonts.fluent.uprimarker" /> | ||
| </Target> |
There was a problem hiding this comment.
The intention of this target is to let Uno correctly detect uprimarker and properly find the font file during ExpandPackageAssets.
| @@ -3,4 +3,8 @@ | |||
| <PropertyGroup Condition="'$(UnoFontsFluentDisableImport)'==''"> | |||
| <UnoPlatformDefaultSymbolsFontFamily>ms-appx://uno.fonts.fluent/Fonts/uno-fluentui-assets.ttf</UnoPlatformDefaultSymbolsFontFamily> | |||
| </PropertyGroup> | |||
|
|
|||
| <Target Name="_UnoAddPriMarker" AfterTargets="ResolvePackageAssets"> | |||
There was a problem hiding this comment.
It could also be BeforeTargets="_UnoFindPackageAssetMarkers". I think both should work.
There was a problem hiding this comment.
I wanted to avoid relying on an internal implementation detail of the marker resolution assembly (assuming that most libraries will also contain code). We still have additional work to do on fonts (default text font), and this may be part of it to include a more robust way of creating font-only packages.
There was a problem hiding this comment.
I'm not sure I understand the problem with relying on the internal implementation detail. But anyway, let me revert this part for now.
There was a problem hiding this comment.
The use of _UnoPriFiles is an internal implementation detail at this time.
There was a problem hiding this comment.
@jeromelaban Does it look better now?
Youssef1313
changed the title
IMPORTANT: I haven't verified if the package still works as intended. This is important before merging. @jeromelaban Would you be able to do that?
GitHub Issue (If applicable): Closes #24
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):