Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NavigationBar][iOS][Android] Cannot use Converters for properties on NavigationBar and AppBarButton on mobile #381

Closed
kazo0 opened this issue Oct 27, 2022 · 0 comments · Fixed by #622
Closed

[NavigationBar][iOS][Android] Cannot use Converters for properties on NavigationBar and AppBarButton on mobile #381

kazo0 opened this issue Oct 27, 2022 · 0 comments · Fixed by #622
Assignees
@kazo0 @Arieldelossantos
Labels
control/navigationbar kind/bug Something isn't working

Comments

@kazo0
Copy link
Contributor

kazo0 commented Oct 27, 2022

See this issue

So it appears that we cannot use a Converter when setting the Background of the NavigationBar. For some reason, it breaks the nested registration of the PropertyChanged callback here:

uno.toolkit.ui/src/Uno.Toolkit.UI/Controls/NavigationBar/NavigationBarRenderer.Android.cs

Lines 151 to 153 in 650812a

new[] { NavigationBar.BackgroundProperty },
new[] { NavigationBar.BackgroundProperty, SolidColorBrush.ColorProperty },
new[] { NavigationBar.BackgroundProperty, SolidColorBrush.OpacityProperty },

@kazo0 kazo0 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. labels Oct 27, 2022
@kazo0 kazo0 self-assigned this Oct 27, 2022
@kazo0 kazo0 mentioned this issue Nov 18, 2022
Open
@kazo0 kazo0 added control/navigationbar and removed triage/untriaged Indicates an issue requires triaging or verification. labels Jan 31, 2023
@kazo0 kazo0 mentioned this issue Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazo0 kazo0

@Arieldelossantos Arieldelossantos

Labels
control/navigationbar kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Properly resubscribe to nested prop changes unoplatform/uno.toolkit.ui
2 participants
@kazo0 @Arieldelossantos