Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawer): attached property crash #1056

Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix(drawer): attached property crash #1056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7824092
fix(drawer): attached property crash
Xiaoy312 Feb 29, 2024
4501bd8
chore: address ci build errors
Xiaoy312 Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/workflow/cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"version": "0.2",
"language": "en",
"words": [
"autoplay",
"Avalonia",
"ambiently",
"binlog",
Expand Down
1 change: 0 additions & 1 deletion doc/helpers/StatusBar-extensions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ Provides two attached properties on `Page` to control the visuals of the status
</iframe>
</div>


## Remarks

The attached properties do nothing on platforms other than iOS and Android.
Expand Down
8 changes: 4 additions & 4 deletions src/Uno.Toolkit.UI/Behaviors/DrawerControlBehavior.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ public static class DrawerControlBehavior
new PropertyMetadata(default(Brush)));

[DynamicDependency(nameof(SetDrawerBackground))]
public static Brush GetDrawerBackground(DrawerControl obj) => (Brush)obj.GetValue(DrawerBackgroundProperty);
public static Brush GetDrawerBackground(DependencyObject obj) => (Brush)obj.GetValue(DrawerBackgroundProperty);

[DynamicDependency(nameof(GetDrawerBackground))]
public static void SetDrawerBackground(DrawerControl obj, Brush value) => obj.SetValue(DrawerBackgroundProperty, value);
public static void SetDrawerBackground(DependencyObject obj, Brush value) => obj.SetValue(DrawerBackgroundProperty, value);

#endregion
#region DependencyProperty: OpenDirection
Expand Down Expand Up @@ -127,9 +127,9 @@ public static class DrawerControlBehavior
new PropertyMetadata(DrawerControl.DefaultValues.FitToDrawerContent));

[DynamicDependency(nameof(SetFitToDrawerContent))]
public static bool GetFitToDrawerContent(DrawerControl obj) => (bool)obj.GetValue(FitToDrawerContentProperty);
public static bool GetFitToDrawerContent(DependencyObject obj) => (bool)obj.GetValue(FitToDrawerContentProperty);
[DynamicDependency(nameof(GetFitToDrawerContent))]
public static void SetFitToDrawerContent(DrawerControl obj, bool value) => obj.SetValue(FitToDrawerContentProperty, value);
public static void SetFitToDrawerContent(DependencyObject obj, bool value) => obj.SetValue(FitToDrawerContentProperty, value);

#endregion
}
Expand Down
Loading