Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autolayout): When SpaceBetween no spacing #433

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

Robert-Louis
Copy link
Contributor

@Robert-Louis Robert-Louis commented Dec 20, 2022

GitHub Issue (If applicable): #1128

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • when in spacebetween the spacing is still use, setting a minimal space between autolayout children

What is the new behavior?

  • when spacebetween the spacing will be ignore

PR Checklist

Please check if your PR fulfills the following requirements:

  • [c] Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • [c] Contains NO breaking changes
  • Updated the Release Notes
  • [c] Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Dec 20, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-433.eastus2.azurestaticapps.net

@jeromelaban
Copy link
Member

@Robert-Louis Are you able to add a test ?

@Robert-Louis
Copy link
Contributor Author

Robert-Louis commented Dec 20, 2022

@jeromelaban I was planning adding test during the day for various autolayout scenario. I'm not 100% at ease with the runtime test so I wanted to take time for this.

@github-actions
Copy link

github-actions bot commented Dec 21, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-433.eastus2.azurestaticapps.net

@Robert-Louis
Copy link
Contributor Author

@jeromelaban I added the test

Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the test is passing :)

@Robert-Louis Robert-Louis merged commit 5f29016 into main Dec 23, 2022
@Robert-Louis Robert-Louis deleted the dev/rlm/spacing-and-spacebetween branch December 23, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants