Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add generic selection support for ItemsRepeater #451

Merged
merged 1 commit into from
Feb 24, 2023
Merged

feat: add generic selection support for ItemsRepeater #451

merged 1 commit into from
Feb 24, 2023

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Jan 17, 2023 •
edited
Loading

GitHub Issue (If applicable): closes #452, closes #395

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230117/chip-itemsrepeater branch from 305a616 to d3fb3b5 Compare January 17, 2023 15:33
@Xiaoy312 Xiaoy312 mentioned this pull request Jan 18, 2023
Closed
6 tasks
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230117/chip-itemsrepeater branch 2 times, most recently from aa1cc8c to dd169fc Compare January 18, 2023 17:54
@Xiaoy312 Xiaoy312 marked this pull request as ready for review January 18, 2023 17:55
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230117/chip-itemsrepeater branch 2 times, most recently from 04ba287 to eef9427 Compare January 18, 2023 19:13
@unoplatform unoplatform deleted a comment from github-actions bot Jan 18, 2023
@unoplatform unoplatform deleted a comment from github-actions bot Jan 18, 2023
@unoplatform unoplatform deleted a comment from github-actions bot Jan 18, 2023
@unoplatform unoplatform deleted a comment from github-actions bot Jan 18, 2023
agneszitte
agneszitte reviewed Jan 18, 2023
View reviewed changes
doc/controls/ChipAndChipGroup.md Outdated Show resolved Hide resolved
doc/controls/ChipAndChipGroup.md Outdated Show resolved Hide resolved
src/Uno.Toolkit.RuntimeTests/Tests/ItemsRepeaterChipTests.cs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 18, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-451.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230117/chip-itemsrepeater branch from 3ab20a5 to 3d63440 Compare January 18, 2023 19:21
@github-actions
Copy link

github-actions bot commented Jan 18, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-451.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 18, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-451.eastus2.azurestaticapps.net

@kazo0 kazo0 mentioned this pull request Jan 18, 2023
Closed
@Xiaoy312 Xiaoy312 enabled auto-merge (squash) January 31, 2023 16:15
@Xiaoy312 Xiaoy312 added the do-not-merge/breaking-change Categorizes issue or PR as related to breaking change to an existing API label Jan 31, 2023
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Jan 31, 2023 •
edited
Loading

todo:

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230117/chip-itemsrepeater branch from 3d63440 to e5f8c69 Compare February 12, 2023 09:17
@github-actions
Copy link

github-actions bot commented Feb 12, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-451.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 changed the title feat: add chip selection support for ItemsRepeater feat: add generic selection support for ItemsRepeater Feb 13, 2023
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230117/chip-itemsrepeater branch from e5f8c69 to 8ed9e19 Compare February 14, 2023 17:25
@Xiaoy312 Xiaoy312 enabled auto-merge (squash) February 14, 2023 17:26
@github-actions
Copy link

github-actions bot commented Feb 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-451.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230117/chip-itemsrepeater branch from 1fb71d7 to 52b96ae Compare February 23, 2023 20:46
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20230117/chip-itemsrepeater branch from 52b96ae to 08c5312 Compare February 23, 2023 20:48
@github-actions
Copy link

github-actions bot commented Feb 23, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-451.eastus2.azurestaticapps.net

@Xiaoy312
Copy link
Contributor Author

last error: https://dev.azure.com/uno-platform/Uno%20Platform/_build/results?buildId=70309&view=ms.vss-test-web.build-test-results-tab&runId=2253503&resultId=100025&paneView=debug

@Xiaoy312 Xiaoy312 merged commit 85fd487 into main Feb 24, 2023
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20230117/chip-itemsrepeater branch February 24, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@agneszitte agneszitte agneszitte left review comments

@kazo0 kazo0 kazo0 approved these changes

Assignees
No one assigned
Labels
do-not-merge/breaking-change Categorizes issue or PR as related to breaking change to an existing API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selection support on Chip within ItemsRepeater ItemsRepeaterExtensions
4 participants
@Xiaoy312 @kazo0 @jeromelaban @agneszitte