Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/xygu/20231103/drawer-flyout-depth #906

Merged
merged 12 commits into from
Nov 21, 2023
Merged

Dev/xygu/20231103/drawer-flyout-depth #906

merged 12 commits into from
Nov 21, 2023

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Nov 6, 2023 •
edited
Loading

GitHub Issue (If applicable): closes #899, fixes #907, fixes #281

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231103/drawer-flyout-depth branch 2 times, most recently from ceec942 to 68c2c1f Compare November 6, 2023 16:54
@Xiaoy312
Copy link
Contributor Author

Xiaoy312 commented Nov 6, 2023 •
edited
Loading

todo:

  • fixme: windows not working:

    Exception thrown at 0x00007FFAD82BCF19 (KernelBase.dll) in Uno.Toolkit.WinUI.Samples.Windows.Desktop.exe: WinRT originate error - 0x802B000A : 'Failed to assign to property 'Uno.Toolkit.UI.DrawerFlyoutPresenter.OpenDirection'. [Line: 639 Position: 606]'.

  • add runtime tests

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231103/drawer-flyout-depth branch from dd18a21 to dc695b9 Compare November 7, 2023 18:35
@agneszitte agneszitte changed the base branch from dev/sb/drawer-flyout-frame to main November 7, 2023 18:56
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231103/drawer-flyout-depth branch from 8b4338a to 1392331 Compare November 9, 2023 21:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-906.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 mentioned this pull request Nov 10, 2023
Closed
12 tasks
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231103/drawer-flyout-depth branch from 102c3d3 to 46b329e Compare November 15, 2023 22:52
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-906.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 marked this pull request as ready for review November 15, 2023 22:53
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-906.eastus2.azurestaticapps.net

kazo0
kazo0 approved these changes Nov 16, 2023
View reviewed changes
doc/controls/DrawerFlyoutPresenter.md Outdated Show resolved Hide resolved
doc/controls/DrawerFlyoutPresenter.md Outdated Show resolved Hide resolved
doc/controls/DrawerFlyoutPresenter.md Outdated Show resolved Hide resolved
doc/controls/DrawerFlyoutPresenter.md Show resolved Hide resolved
doc/controls/DrawerFlyoutPresenter.md Outdated Show resolved Hide resolved
doc/controls/DrawerFlyoutPresenter.md Show resolved Hide resolved
doc/controls/DrawerFlyoutPresenter.md Outdated Show resolved Hide resolved
doc/controls/DrawerFlyoutPresenter.md Outdated Show resolved Hide resolved
doc/controls/DrawerFlyoutPresenter.md Outdated Show resolved Hide resolved
doc/controls/DrawerFlyoutPresenter.md Outdated Show resolved Hide resolved
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231103/drawer-flyout-depth branch from 753a1e5 to 273a31e Compare November 20, 2023 21:32
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20231103/drawer-flyout-depth branch from 273a31e to 2383a03 Compare November 20, 2023 21:34
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-906.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-906.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 merged commit 5850dc6 into main Nov 21, 2023
24 checks passed
@Xiaoy312 Xiaoy312 deleted the dev/xygu/20231103/drawer-flyout-depth branch November 21, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Xiaoy312 @kazo0