-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ResponsiveView #912
feat: ResponsiveView #912
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
To Discuss:1. How we handle Template ContentWhat should be done when, for example, Narrow VisualState is triggered but NarrowContent is uno.toolkit.ui/src/Uno.Toolkit.UI/Controls/ResponsiveView/ResponsiveView.cs Lines 97 to 114 in 67ff5a4
2. How to make the responsive settings global and overridable?2.1 What should be the default setting for ExtraNarrow, Narrow, Default, etc... ?uno.toolkit.ui/src/Uno.Toolkit.UI/Controls/ResponsiveView/ResponsiveView.xaml Lines 7 to 23 in 67ff5a4
3. Properties namingWould it make more sense if the we named them, for example,
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
d917dac
to
7cee9d6
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
2 similar comments
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
@kazo0 and @Xiaoy312 , please note that my latest changes include:
The reason behind this is that using ContentTemplateContent* Using |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
It shouldnt flicker this much on windows, with the Content. You need to cache the last resolved content-template or winning size, and compare this value on size-changed, and only update when the new ones are different than previous. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
1 similar comment
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
6fda9fd
to
bd3b994
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
ResponsiveViewSamplePage
bd3b994
to
a6ed6d4
Compare
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-912.eastus2.azurestaticapps.net |
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):