Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Invalid Ad Control layout #2761

Closed
1 of 12 tasks
jeromelaban opened this issue Mar 9, 2020 · 1 comment · Fixed by #2800
Closed
1 of 12 tasks

[Android] Invalid Ad Control layout #2761

jeromelaban opened this issue Mar 9, 2020 · 1 comment · Fixed by #2800
Assignees
@davidjohnoliver
Labels
kind/regression Something was working, now it isn't

Comments

@jeromelaban
Copy link
Member

Current behavior

A Google Ad control does not layout properly.

How to reproduce it (as minimally and precisely as possible)

TBD
https://dev.azure.com/nventive/Umbrella/_workitems/edit/176391

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Windows
  • Build tasks
  • Solution Templates

Visual Studio:

  • 2017 (version: )
  • 2019 (version: )
  • for Mac (version: )

Relevant plugins:

  • Resharper (version: )

Anything else we need to know?
@jeromelaban jeromelaban added the kind/regression Something was working, now it isn't label Mar 9, 2020
@jeromelaban jeromelaban mentioned this issue Mar 9, 2020
Closed
12 tasks
@carlh98
Copy link
Contributor

carlh98 commented Mar 11, 2020

I've created a branch for the issue origin/dev/cama/ad-banner-cropped
Just launch the project to see the control, the xaml is in the WhatsOnPage.xaml

The issue comes from line 102 of Layouter.cs where ".AtLeast(minSize)" was removed
f471952#diff-1ccb3af58d327b57ec29a1d227d9cf2a

@davidjohnoliver davidjohnoliver self-assigned this Mar 12, 2020
@davidjohnoliver davidjohnoliver mentioned this issue Mar 12, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidjohnoliver davidjohnoliver

Labels
kind/regression Something was working, now it isn't
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Android] Include Margin when measuring from LayoutManager unoplatform/uno
3 participants
@jeromelaban @carlh98 @davidjohnoliver