Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WASM/Skia/Android] Elements being clipped within a Grid with a negative margin #7061

Closed
kazo0 opened this issue Sep 13, 2021 · 5 comments · Fixed by #13695
Closed

[WASM/Skia/Android] Elements being clipped within a Grid with a negative margin #7061

kazo0 opened this issue Sep 13, 2021 · 5 comments · Fixed by #13695
Assignees
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)

Comments

@kazo0
Copy link
Contributor

kazo0 commented Sep 13, 2021

Current behavior

Place a child Grid inside of a parent Grid. With a negative margin on the child Grid, it should not be clipped by the parent Grid.

Observe that the child Grid is being improperly clipped:

image

Expected behavior

WinUI behaviour:

image

How to reproduce it (as minimally and precisely as possible)

<Grid Width="100"
	Height="100"
	Background="Purple">
	<Grid Margin="0, -4, -4, 0"
		Background="Yellow"
		VerticalAlignment="Top"
		HorizontalAlignment="Right">
		<Ellipse Height="30"
				Width="30" Fill="Red"/>
	</Grid>
</Grid>

Workaround

No response

Works on UWP/WinUI

Yes

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia

NuGet package version(s)

No response

Affected platforms

Android, WebAssembly, Skia (GTK on Linux/macOS/Windows)

IDE

Visual Studio 2019

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

Works on iOS

@kazo0 kazo0 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Sep 13, 2021
@jeromelaban jeromelaban added project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform and removed triage/untriaged Indicates an issue requires triaging or verification labels Sep 13, 2021
@kazo0 kazo0 added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label Sep 14, 2021
@MartinZikmund
Copy link
Member

@kazo0 Can you check if this still happens? I have checked with the repro and it seems the clipping does not happen anymore on any of the mentioned platforms

@MartinZikmund MartinZikmund added the triage/potentially-fixed Categorizes an issue as potentially fixed by some unlinked PR, fix needs to be verified label Jan 8, 2022
@Marc-Antoine-Soucy
Copy link

So, while testing, at the begining, I left a textblock that would tell me what version of Uno we were using, this is the result:

Windows:
image

Wasm:
image

Android:
image

Skia:
image

With the textblock, it seems to be fixed on Android, but still an issue on WASM and Skia (to a lesser extent)

Without the textblock it is fixed everywhere, should this be closed and another issue opened?

@jeromelaban
Copy link
Member

@dr1rrb is it what #12428 will fix?

@dr1rrb
Copy link
Member

dr1rrb commented Jun 5, 2023

@dr1rrb is it what #12428 will fix?

Unfortunately not

@jeromelaban jeromelaban removed the triage/potentially-fixed Categorizes an issue as potentially fixed by some unlinked PR, fix needs to be verified label Jun 6, 2023
@MartinZikmund MartinZikmund changed the title [WASM/Skia/Android] Elements being clipped within a Grid with a negative margin [WASM/Skia/Android] Elements being clipped within a Grid with a negative margin Jul 18, 2023
@MartinZikmund MartinZikmund added difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jul 18, 2023
@Youssef1313 Youssef1313 self-assigned this Aug 30, 2023
@Youssef1313
Copy link
Member

#13391 might help. Let's see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/bug Something isn't working platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants