Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NavigationMenu recursive issue causing crash #197

Merged
merged 1 commit into from
Jul 16, 2023
Merged

fix: NavigationMenu recursive issue causing crash #197

merged 1 commit into from
Jul 16, 2023

Conversation

zernonia
Copy link
Member

Remove setRef causing the rendering recursive issue

@zernonia zernonia requested a review from k11q July 16, 2023 07:43
@zernonia zernonia self-assigned this Jul 16, 2023
@zernonia zernonia linked an issue Jul 16, 2023 that may be closed by this pull request
Navigation Menu crashing #196
Closed
k11q
k11q approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@k11q k11q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k11q k11q merged commit 79e5928 into main Jul 16, 2023
@k11q k11q deleted the 196-navigation-menu-crashing branch July 16, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k11q k11q k11q approved these changes

Assignees

@zernonia zernonia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation Menu crashing
2 participants
@zernonia @k11q