Merge pull request #5 from unrec/rename-rated-item

Rename RatedItem class
unrec · Dec 2, 2022 · a2e4096 · a2e4096
2 parents 35bec40 + c67d0ff
commit a2e4096
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 16 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -1,6 +1,6 @@
 import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
 
-version = "0.0.2"
+version = "0.0.3"
 group = "com.unrec"
 description = "imdb-csv-parser"
 java.sourceCompatibility = JavaVersion.VERSION_11

diff --git a/src/main/kotlin/com/unrec/imdb/csv/parser/ImdbCsvParser.kt b/src/main/kotlin/com/unrec/imdb/csv/parser/ImdbCsvParser.kt
@@ -33,17 +33,17 @@ class ImdbCsvParser {
         .addArrayColumn("Directors")
         .build()
 
-    fun parse(inputStream: InputStream): List<RatedItem> {
-        return csvMapper.readerFor(RatedItem::class.java)
+    fun parse(inputStream: InputStream): List<ParsedItem> {
+        return csvMapper.readerFor(ParsedItem::class.java)
             .with(schema)
-            .readValues<RatedItem>(inputStream)
+            .readValues<ParsedItem>(inputStream)
             .readAll()
     }
 
-    fun parse(file: File): List<RatedItem> {
-        return csvMapper.readerFor(RatedItem::class.java)
+    fun parse(file: File): List<ParsedItem> {
+        return csvMapper.readerFor(ParsedItem::class.java)
             .with(schema)
-            .readValues<RatedItem>(file)
+            .readValues<ParsedItem>(file)
             .readAll()
     }
 }
diff --git a/...in/com/unrec/imdb/csv/parser/RatedItem.kt → ...n/com/unrec/imdb/csv/parser/ParsedItem.kt b/...in/com/unrec/imdb/csv/parser/RatedItem.kt → ...n/com/unrec/imdb/csv/parser/ParsedItem.kt
@@ -4,7 +4,7 @@ import com.fasterxml.jackson.annotation.JsonFormat
 import com.fasterxml.jackson.annotation.JsonProperty
 import java.time.LocalDate
 
-data class RatedItem(
+data class ParsedItem(
     @field:JsonProperty("Const")
     val id: String? = null,
 

diff --git a/src/test/kotlin/com/unrec/imdb/csv/parser/ImdbCsvParserTest.kt b/src/test/kotlin/com/unrec/imdb/csv/parser/ImdbCsvParserTest.kt
@@ -33,7 +33,7 @@ internal class ImdbCsvParserTest {
     @Test
     internal fun `Parse 5 exact records from the File`() {
         // given
-        val ratedItems = TestData.ratedItems
+        val ratedItems = TestData.parsedItems
 
         // when
         val items = parser.parse(File(pathToFiveItems))
@@ -42,7 +42,7 @@ internal class ImdbCsvParserTest {
         items.size shouldBe 5
         items.forEach { item ->
             val ratedItem = ratedItems.find { it.id == item.id }!!
-            item.shouldBeEqualToIgnoringFields(ratedItem, RatedItem::genres, RatedItem::directors)
+            item.shouldBeEqualToIgnoringFields(ratedItem, ParsedItem::genres, ParsedItem::directors)
             item.directors shouldContainExactlyInAnyOrder ratedItem.directors
             item.genres shouldContainExactlyInAnyOrder ratedItem.genres
         }

diff --git a/src/test/kotlin/com/unrec/imdb/csv/parser/TestData.kt b/src/test/kotlin/com/unrec/imdb/csv/parser/TestData.kt
@@ -4,8 +4,8 @@ import java.time.LocalDate
 
 object TestData {
 
-    val ratedItems = listOf(
-        RatedItem(
+    val parsedItems = listOf(
+        ParsedItem(
             "tt0110912",
             10,
             LocalDate.parse("2010-01-17"),
@@ -20,7 +20,7 @@ object TestData {
             LocalDate.parse("1994-05-21"),
             listOf("Quentin Tarantino")
         ),
-        RatedItem(
+        ParsedItem(
             "tt0401792",
             10,
             LocalDate.parse("2019-10-21"),
@@ -35,7 +35,7 @@ object TestData {
             LocalDate.parse("2005-03-28"),
             listOf("Frank Miller", "Quentin Tarantino", "Robert Rodriguez")
         ),
-        RatedItem(
+        ParsedItem(
             "tt7366338",
             9,
             LocalDate.parse("2019-06-14"),
@@ -50,7 +50,7 @@ object TestData {
             LocalDate.parse("2019-05-06"),
             emptyList()
         ),
-        RatedItem(
+        ParsedItem(
             "tt1625351",
             6,
             LocalDate.parse("2011-03-18"),
@@ -65,7 +65,7 @@ object TestData {
             LocalDate.parse("2011-02-27"),
             listOf("Don Mischer", "Troy Miller")
         ),
-        RatedItem(
+        ParsedItem(
             "tt0291337",
             10,
             LocalDate.parse("2010-02-11"),