Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pull_request event types #10

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

patrickeasters
Copy link
Contributor

I had a use case where I wanted to comment on a PR during a pull_request event type, so I added this support. This is completely backwards compatible with the existing behavior for push events.

Copy link

@FarhanSajid1 FarhanSajid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me, this should be merged immediately

@FarhanSajid1
Copy link

@aaronklaassen can you merge approve the merge?

@FarhanSajid1
Copy link

FarhanSajid1 commented Dec 24, 2019

@patrickeasters if this doesn’t get merged I could use your repo and branch to run my git action, or should I fork over your repo and use it that way?

@patrickeasters
Copy link
Contributor Author

@FarhanSajid1 you're welcome to fork my repo with the fix or reference it: patrickeasters/comment-on-pr@v1.1.2

@aaronklaassen
Copy link
Member

aaronklaassen commented Dec 24, 2019

Oh, thanks! I've been meaning to add this, too. You beat me to it 👍

Sorry for the wait. Apparently I missed the notification for this open PR 😬

@aaronklaassen aaronklaassen merged commit a35cc2b into unsplash:master Dec 24, 2019
samsucik added a commit to samsucik/comment-on-pr that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants