chore: revert custom changes to autogenerated code #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
The v2 python client has some minor breaking changes for our users, both related to keyword parameters:
partition_parameters
field.becomes
general.partition
no longer allows for positional args.Instead of
we have to do
The first approach
These are minimal changes, but they will disrupt a number of users who have copied our sample snippets in the past. My workaround for this was to manually patch the autogenerated code to bring back positional params. However, this will be messy in the long term, as we now have to apply our changes after every regenerate. Instead, let's embrace the version bump to 0.16.0 and just document the breaking change.
Update: The python snippet in the serverless dashboard uses keyword args, so users who copied this out are unaffected.
Changes
request
as a positional arg ingeneral.partition
(general.py
)PartitionRequest
so we don't have to use a keyword arg